Context-form retrofit (batch 10, final): OrnetBrowser (10 functions)#915
Merged
Conversation
Batch 10 (final, solo). All 10 OrnetBrowser functions 4-arg -> def fn(context);
ornetbrowser_thumbnails ('Location') and ornetbrowser_usageinfo ('Path') have
path columns, the other 8 return a full source_path now relativized. Kept the
W0718 disable for the existing except Exception blocks (nested is_sqlite_db /
usageinfo). pylint 10.00.
Completes the ALEAPP context-form retrofit (28 artifacts where get_relative_path
improves output).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 10 — OrnetBrowser solo (10 functions), the final batch of the ALEAPP context-form retrofit.
Location) + ornetbrowser_usageinfo (Path) — path columns.source_path(db), now relativized.# pylint: disable=W0718for the existingexcept Exceptionblocks (nestedis_sqlite_dbhelpers + usageinfo); droppedW0613.pylint 10.00, all 10 context form, imports clean, 11
get_relative_pathapplications.🎉 28 of 28 done — completes the retrofit of every ALEAPP artifact where
get_relative_pathimproves output (a full path leaking into a data column).